Make Profiler service an optional argument for SymfonyProfilerController #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
welcoMattic approved these changes Jun 7, 2021
| I see some tests failed on new Symfony 5.3 :/ Any ideas on how to fix them? |
rvanlaak reviewed Jun 8, 2021
| - '@profiler' | ||
| - '%php_translation.toolbar.allow_edit%' | ||
| calls: | ||
| - setProfiler: ['@?profiler'] |
There was a problem hiding this comment.
Will this throw an exception in combination with the non-nullable typehint on the setter?
There was a problem hiding this comment.
Good question! I tried this when was coding and no exception was thrown. It looks like Symfony just does not call that setProfiler() method at all if the @profiler service unavailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #436
These changes allow us to keep the profiler feature enabled by default in the recipe: https://github.com/symfony/recipes-contrib/blob/ff7313b337a4c0ec894684f71b62240a31816e9f/php-translation/symfony-bundle/0.10/config/packages/dev/php_translation.yaml#L3 to have good discoverability of the feature for those who have the
symfony/web-profiler-bundleinstalled but won't throw an exception if thesymfony/web-profiler-bundleis missing in the project oncomposer require php-translation/symfony-bundle. If somehow this feature will be tried to use - we will show a clear user-friendly message about requiringsymfony/web-profiler-bundledependency first.