Skip to content

Conversation

@eclyptox
Copy link
Contributor

If translating collaboratively translation results sort differs from each developer that runs the command.

If translating collaboratively translation results sort differs from each developer that runs the command.
@bocharsky-bw
Copy link
Member

Thank you for this contribution! Hm, I still can't quite understand how it's possible, why translation results sort differs from each developer? Are we talking about running the command on different OS? Does Finder somehow randomly iterate files? Just wonder about it

@bocharsky-bw
Copy link
Member

@eclyptox Thank you for this suggestion! Could you (or anyone) give a bit more context about the initial problem here? I'm looking forward to merging it but can't understand how sort will help with it, basically these questions: #435 (comment)

@eclyptox
Copy link
Contributor Author

Thank you for this contribution! Hm, I still can't quite understand how it's possible, why translation results sort differs from each developer? Are we talking about running the command on different OS? Does Finder somehow randomly iterate files? Just wonder about it

The problem is that finder by default sort by last modified date. So, if two people in the same project work on different templates, the result will be different. That is why I changed the sorting.

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, last modified date! Thank you for providing more info! Makes perfect sense to me now 👍

@bocharsky-bw bocharsky-bw merged commit f80167d into php-translation:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants