Add support for arbitrary options to StorageInterface::export()/import() #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rvanlaak reviewed Jan 7, 2020
welcoMattic approved these changes Jan 7, 2020
| Is it a good idea to add the same logic in the download command? |
Im not sure... I just updated the baseline...
Yeah, I think so. I'll update the the PR. |
| I've updated the PR. It is ready for another review. |
welcoMattic approved these changes Jan 18, 2020
| Thank you for the review |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will partly fix #326
Are the names
import-conf/export-confgood enough? Should they be replaced withdownload/upload? (export = download, since the function is on the StorageInterface, exporting from a storage is taking things out of it...)