Skip to content

Update symfony-storage requirement #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

Update symfony-storage requirement #374

merged 1 commit into from
Jan 6, 2020

Conversation

@odolbeau
Copy link
Member

Fix #373
@odolbeau
Copy link
Member Author

It looks like phpstan is ran against latest vendors version (master) due to "minimum-stability": "dev" in our composer.json.

Should we:

  1. Keep running phpstan against non stable version & remove this error message?
  2. Keep "minimum-stability": "dev" & find a way to run phpstan against latest stable vendor versions? (maybe using docker://jakzal/phpqa:php7.3-alpine instead of docker://oskarstark/phpstan-ga)
  3. Remove "minimum-stability": "dev" from our composer.json?

I'll create a new PR to try solution 2.
@odolbeau
Copy link
Member Author

odolbeau commented Dec 30, 2019 •
edited
Loading

Changing the docker image is not enough to have solution 2. working (see #375 )
This was referenced Dec 30, 2019
Merged
Merged
Nyholm
Nyholm approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

It should be green now when #375 is merged.
@Nyholm Nyholm merged commit b519b0d into php-translation:master Jan 6, 2020
@odolbeau odolbeau deleted the bump-requirements branch January 8, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@odolbeau @Nyholm