Deal with Translator interface coming from component (3.4) & contract… #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
odolbeau force-pushed the deal-with-translator-interface branch from 94421c7 to 0e712fe Compare odolbeau force-pushed the deal-with-translator-interface branch from 0e712fe to 7b013a9 Compare 
welcoMattic approved these changes Nov 29, 2019
rvanlaak approved these changes Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
TranslatorInterfacelocated in the translation component will be removed in 5.x, replace by theTranslatorInterfacelocated in contracts.This PR allow us to deal with both
TranslatorInterface.