Skip to content

Added Symfony 4 compatibility and refactored code #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Added Symfony 4 compatibility and refactored code #345

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9db41a0
Added Symfony 4 compatibility and refactored code
junaidbinfarooq Nov 13, 2019
0b6c5b5
+ Replaced Controller with AbstractController in the controllers
Nov 19, 2019
2223f92
+ Registered controllers as services
Nov 20, 2019
fa9c8d7
+ Removed accidental commit
Nov 20, 2019
f6cebf5
+ Now importing the new service file `controllers.yml` in Translation…
Nov 20, 2019
5a1dfcf
+ CS-fix
Nov 20, 2019
b128fc0
Merge branch 'master' into patch-1
junaidbinfarooq Nov 28, 2019
a48fb01
Add I/O type hinting, use null coalescing operator
Oct 30, 2019
b2597de
documentation fixes for phpstan lvl 2
rvanlaak Nov 5, 2019
8395971
Throw Exception if no configuration found, update I/O type hinting
Nov 8, 2019
89d1df3
Fix CS
Nov 8, 2019
74234e3
+ CS-fix
Nov 20, 2019
e61d799
+ CS-fix
Nov 28, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+ CS-fix
  • Loading branch information
Junaid committed Nov 28, 2019
commit 74234e3826f9ac6f2901682d22736f314b60dab3
1 change: 0 additions & 1 deletion DependencyInjection/TranslationExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ public function getAlias(): string
return 'translation';
}


private function createChildDefinition(string $parent): ChildDefinition
{
return new ChildDefinition($parent);
Expand Down