Fix codestyle after uptream release of cs-fixer

[rvanlaak]

The default CS-Fixer configurations for @Symfony has been updated.

See related comments from #342 (comment) until #342 (comment)

If wanted we can also add the related Makefile to this PR:

# Makefile DIR := ${CURDIR} phpstan:	docker run --rm -v $(DIR):/project -w /project jakzal/phpqa:php7.1-alpine phpstan analyze codestyle:	docker run --rm -v $(DIR):/project -w /project jakzal/phpqa:php7.1-alpine php-cs-fixer fix

[welcoMattic]

As we support PHP >= 7.1, we should prefer type hinting instead of PHPDoc. This PR could be the best place to fix it once for all, WDYT?

[rvanlaak]

@welcoMattic that is exactly where #342 focuses on 👍

This PR is there to get master green again because of the upstream change to CS-Fixer.

[welcoMattic]

LGTM 👏

[XWB]

You could also set no_superfluous_phpdoc_tags to false. I don't like that the doc comments are getting removed.

[rvanlaak]

Same here, although I like that the lines of code gets reduced in this case. But, it is a bit hard to debate personal cs preference 😉

Imho following a standard cs set like the @Symfony we currently follow should be the leading choice, so other contributors can know what code style to expect.

Maybe the arguments for choosing @Symfony is something to document?

[XWB]

Imho following a standard cs set like the @symfony we currently follow should be the leading choice, so other contributors can know what code style to expect.

Sure, we could do that. But if the main purpose is to make master green again, setting no_superfluous_phpdoc_tags to false would achieve that too without introducing a new CS.

[rvanlaak]

Merging this so @ker0x can get his PR #342 green again