Use native_function_invocations #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rvanlaak reviewed Sep 6, 2019
| '@Symfony:risky' => true, | ||
| 'array_syntax' => array('syntax' => 'short'), | ||
| 'native_function_invocation' => false, // True | ||
| 'native_function_invocation' => true, |
There was a problem hiding this comment.
This rule already should be part of @Symfony:risky, so it could get removed?
There was a problem hiding this comment.
Hm.. I just tested.. But I get different results if I use true or if I remove the line.
remove - 14 files changed
true - 40 files changes.
rvanlaak approved these changes Sep 6, 2019
Nyholm force-pushed the native-functions branch from 949f1a5 to b6bfd8f Compare Nyholm force-pushed the native-functions branch from d865ab2 to 1ab3959 Compare | Thank you for the review. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes our PHP-cs-fixer config and the rest of the changes comes from running
php-cs-fixer fix.