Skip to content

[Js] Fix registering custom elements #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

[Js] Fix registering custom elements #312

merged 1 commit into from
Jul 19, 2019

Conversation

@Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Jun 19, 2019 •
edited
Loading

document.registerElement() doesn't exist anymore at least in Firefox. According to MDN Documentation, it has been replaced by customElements.define().

Close #270
@Lctrs
Copy link
Contributor Author

Lctrs commented Jun 19, 2019

cc @webmasterMeyers
@welcoMattic
Copy link
Member

@Lctrs good catch! Thanks for contributing

@bocharsky-bw I think we can merge this one, as tests are green
bocharsky-bw
bocharsky-bw approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, changes look good to me too 👍
@bocharsky-bw
Copy link
Member

Thank you for this fix and the review, guys!
@bocharsky-bw bocharsky-bw merged commit 2da9931 into php-translation:master Jul 19, 2019
@Lctrs Lctrs deleted the fix-registering-custom-elements branch July 19, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Lctrs @welcoMattic @bocharsky-bw