Skip to content

Fix compatibility with Symfony 4.3 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix compatibility with Symfony 4.3 #311

merged 2 commits into from
Jun 24, 2019

Conversation

@albingi
Copy link
Contributor

@albingi albingi commented Jun 18, 2019

The block name change from panelContent to panel
@albingi
Fix compatibility with Symfony 4.3
b0ca60f 
The block name change from panelContent to panel
@bocharsky-bw
Copy link
Member

Hey @albingi thank you for fixing it! Btw, do you have any reference to this change? Actually, it might be a possible BC break for those who are not on Symfony 4.3, so probably we should workaround this in some way
@albingi
Copy link
Contributor Author

albingi commented Jun 18, 2019

Yes, this is about this commit :
symfony/web-profiler-bundle@a92e0ba#diff-3e3f9f89f28a037c50c1714c5a21b3c4
@bocharsky-bw bocharsky-bw mentioned this pull request Jun 24, 2019
Closed
@Nyholm
Copy link
Member

Nyholm commented Jun 24, 2019

@NullIsNot0 Could you review this?
fsoedjede
fsoedjede reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@fsoedjede fsoedjede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and this change fix the issue
@bocharsky-bw
Copy link
Member

@Nyholm FYI I suppose only you can merge PRs in php-translation organization if tests are broken. Other core members can just merge PRs if at least one core member approved it (except the author of PR) and when tests passed. As you can see, all the tests are broken lately, so I opened #313 to fix them. Would be good to have your review on it
NullIsNot0
NullIsNot0 approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@NullIsNot0 NullIsNot0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, that changes work for Symfony 4.3
@Nyholm Nyholm merged commit ffca135 into php-translation:master Jun 24, 2019
@Nyholm
Copy link
Member

Nyholm commented Jun 24, 2019

Thank you for the reviews and for the fix
@bobdenotter bobdenotter mentioned this pull request Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@albingi @bocharsky-bw @Nyholm @fsoedjede @NullIsNot0