Fix delete obsolete translations command on non-interactive cli #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rvanlaak approved these changes Apr 10, 2019
bocharsky-bw approved these changes Apr 12, 2019
| @mdeboer Could you rebase with latest changes in master to see if tests pass here, please? |
| Sure, no problem 👍 |
Fixes the translationdelete-obsolete command not running in non-interactive shells. The question was simply never asked, not even when 'yes'. This fix will run the command (assume yes) on non-interactive shells which allows you to run the command in scripts (e.g. update a lot of translations).
| There we go, all done! 🎉 |
| Awesome! Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes the translationdelete-obsolete command not running in non-interactive shells. The question was simply never asked, not even when using 'yes'. This fix will run the command (assume yes) on non-interactive shells which allows you to run the command in scripts (e.g. update a lot of translations).