Removed EditInPlaceMessage #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
damienalexandre requested changes Aug 19, 2017
Controller/EditInPlaceController.php Outdated
| $message->setMessage($value); | ||
| $message->setTranslation($value); | ||
| $message->setDomain($domain); | ||
| $message->setDomain($locale); |
| Thank you for the review. I will merge #128 first and then make sure to write some tests to this PR to make sure the validation works. |
Nyholm force-pushed the patch-editinPlace branch from b5ffd3e to ce8628c Compare 
rvanlaak reviewed Aug 20, 2017
| list($domain, $translationKey) = explode('|', $key); | ||
| | ||
| $message = new EditInPlaceMessage(); | ||
| $message = new Message(); |
There was a problem hiding this comment.
Based on this PR it seems the common Message can be made immutable (by removing setters and adding constructor arguments). Am I right about this?
There was a problem hiding this comment.
Yeah, for this use case.. But do we want it immutable? hm, maybe we do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We can use Common\Message instead