This repository was archived by the owner on Jul 24, 2024. It is now read-only.
parser: introduce new Precedence and Associativity enums #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ryangjchandler force-pushed the refactor/operator-precedence branch from 80f14ed to f1b82a5 Compare 
ryangjchandler force-pushed the refactor/operator-precedence branch from f1b82a5 to 5874fc5 Compare 
| So the code has been updated to use the new Some of the tests are failing presumably because of the missing associativity rules. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The existing precedence parsing using binding powers is getting quite confusing. Since PHP provides a nice list of operator precedences already, it makes sense to use that same scale ourselves in the parser.
The goal will be:
PrecedenceandAssociativityOnce that's done, it should be incredibly simple to get new operators added in.