This repository was archived by the owner on Jul 24, 2024. It is now read-only.
chore: keep track of the position in the span, and improve the array parser #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
azjezz commented Dec 22, 2022
Comment on lines -187 to -201
| pub fn bracketed<T>( | ||
| state: &mut State, | ||
| func: &(dyn Fn(&mut State) -> ParseResult<T>), | ||
| ) -> ParseResult<Bracketed<T>> { | ||
| let left_bracket = skip_left_bracket(state)?; | ||
| let inner = func(state)?; | ||
| let right_bracket = skip_right_bracket(state)?; | ||
| | ||
| Ok(Bracketed { | ||
| left_bracket, | ||
| inner, | ||
| right_bracket, | ||
| }) | ||
| } | ||
| |
Collaborator Author
There was a problem hiding this comment.
i believe i made a mistake by introducing these, the only one that should be kept is CommaSeparated.
azjezz force-pushed the chore/position-arrays branch 2 times, most recently from 409772d to 5aa72b8 Compare 
…parser Signed-off-by: azjezz <azjezz@protonmail.com>
azjezz force-pushed the chore/position-arrays branch from 5aa72b8 to f5093e4 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.