This repository was archived by the owner on Jul 24, 2024. It is now read-only.
lexer&parser: full heredoc/nowdoc support #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ryangjchandler changed the title ryangjchandler force-pushed the rc/proper-heredoc-nowdoc-impl branch 3 times, most recently from e535ef3 to 7e963cd Compare 
ryangjchandler force-pushed the rc/proper-heredoc-nowdoc-impl branch from eac9270 to 9bfd584 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #22.
There's a few FIXMEs in here, because it's late and I just wanted to get it all working. Will come back on a FIXME roulette later and sort those out.
Noteworthy additions in this PR are the
meta/snapshotandmeta/dumpscripts. Shorthands for running thesnapshotbinary andphp-parser-rsbinary, saves some typing.