Skip to content

[Plugin] Add VCR Record & Replay plugins #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 30, 2019
Merged

[Plugin] Add VCR Record & Replay plugins #3

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
61683f5
[Plugin] Add VCR Record & Replay plugins
GaryPEGEOT Mar 24, 2019
fe64879
Add doc, simplify options
GaryPEGEOT Mar 25, 2019
5cd1243
Record unless replayed
GaryPEGEOT Mar 25, 2019
42412b7
Update class doc
GaryPEGEOT Mar 25, 2019
3f0af84
Fix PHPUnit bridge version
GaryPEGEOT Mar 25, 2019
9939eff
Test that file is actually created
GaryPEGEOT Mar 25, 2019
b4fc311
Update class doc
GaryPEGEOT Mar 27, 2019
76fab38
Optionnaly throw on recorder miss
GaryPEGEOT Mar 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Record unless replayed
  • Loading branch information
@GaryPEGEOT
GaryPEGEOT committed Mar 25, 2019
commit 5cd124324ef00536687566ccf467064059c543ab
2 changes: 1 addition & 1 deletion src/RecordPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function handleRequest(RequestInterface $request, callable $next, callabl
$name = $this->namingStrategy->name($request);

return $next($request)->then(function (ResponseInterface $response) use ($name) {
if ($response->getStatusCode() < 300 && !$response->hasHeader(ReplayPlugin::HEADER_NAME)) {
if (!$response->hasHeader(ReplayPlugin::HEADER_NAME)) {
$this->recorder->record($name, $response);
$response = $response->withAddedHeader(static::HEADER_NAME, $name);
}
Expand Down