Support psr/log 2, 3 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dbu approved these changes Feb 15, 2023
There was a problem hiding this comment.
awesome, thanks!
can you please fix the codestyle things in the stub?
the code coverage error is a setup problem and not related to your pull request, we can ignore that one here. (and i think my solution will be to drop that test, i don't think anyone looks at the coverage metrics of this package)
recca0120 force-pushed the upgrade-psr-log branch 3 times, most recently from 027d750 to 9a33d38 Compare | fixed |
dbu reviewed Feb 16, 2023
| apart from the intellij configuration file, this looks good now 👍 i will merge as soon as you can remove that. |
recca0120 force-pushed the upgrade-psr-log branch from 9a33d38 to 8aaa3c7 Compare 
| thank you! tagged as https://github.com/php-http/vcr-plugin/releases/tag/1.2.2 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What's in this PR?
support psr/log 2, 3
Why?
some third packages require psr/log 3