Skip to content

Conversation

ddeboer
Copy link
Contributor

@ddeboer ddeboer commented Jan 12, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Replace Travis setup with a GitHub Actions workflow.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here
@ddeboer ddeboer mentioned this pull request Jan 12, 2022
3 tasks
@dbu
Copy link
Contributor

dbu commented Jan 12, 2022

thanks a lot!

can you rename coverage to "coverage & static" or something like that? and run it on php 8.0? there is a gazillion errors about return types raised by phpstan, i think they would not occur on 8.0.

then we can later separately address the 8.1 deprecations.

@ddeboer
Copy link
Contributor Author

ddeboer commented Jan 12, 2022

Done.

@dbu dbu merged commit 3ebe5f0 into php-http:master Jan 12, 2022
@dbu
Copy link
Contributor

dbu commented Jan 12, 2022

thanks a ton!

@ddeboer ddeboer deleted the github-action branch January 12, 2022 13:49
@dbu
Copy link
Contributor

dbu commented Jan 12, 2022

i thought scrutinizer failed in your fork because it is not the same repository. still fails here. i wonder what we should do. not sure if we need scrutinizer, imho we could also just drop that step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants