make Promise use template for exception #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 task
dbu force-pushed the template-exception branch 3 times, most recently from b06af4c to be2baa8 Compare in httplug, we have documentation text that formulates that only specific exceptions may be used for the callback. the change in 1.2.0 to allow any Throwable was incorrect.
dbu force-pushed the template-exception branch from be2baa8 to 4874a14 Compare 
dbu commented Jan 3, 2024
| * @param callable(E): V|null $onRejected called when an exception occurs | ||
| * | ||
| * @return Promise<V> a new resolved promise with value of the executed callback (onFulfilled / onRejected) | ||
| * @return Promise<V, E> a new resolved promise with value of the executed callback (onFulfilled / onRejected) |
There was a problem hiding this comment.
we have T, V and E - how do we correctly specify this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What's in this PR?
have Promise use a template for the exception class.
Why?
in httplug, we have documentation text that formulates that only specific exceptions may be used for the callback. the change in 1.2.0 to allow any Throwable was incorrect.
Usage
See https://phpstan.org/r/6ec99fad-fd67-4f64-ac0d-ba135e207700