Remove static MimetypeHelper. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Fix issue #4
Member Author
| Ping @dbu |
| return $this->mimetypeHelper; | ||
| } | ||
| | ||
| /** |
Contributor
There was a problem hiding this comment.
i would add a doc here that explains this is to overwrite the default mimetype helper if one needs custom behaviour.
Contributor
| looks good. i seem to not have been subscribed to this repo, watching it now. |
Member Author
| Thank you |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix issue #4
This will allow you to use whatever mimetype helper you want.