Skip to content

change basename to pathinfo #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2016
Merged

change basename to pathinfo #18

merged 1 commit into from
Dec 21, 2016

Conversation

GreenSuslik
Copy link
Contributor

Detail #16
@Nyholm
Copy link
Member

Nyholm commented Dec 21, 2016

Thank you for this!
@Nyholm Nyholm merged commit 0d1b2d7 into php-http:master Dec 21, 2016
@Nyholm Nyholm mentioned this pull request Dec 21, 2016
Closed
@sagikazarmark
Copy link
Member

Looks ok to me: https://3v4l.org/9gkFR

Might worth bringig up the issue here as well: https://github.com/webmozart/path-util/blob/master/src/Path.php#L330

It's a nice path utility package.
@Nyholm
Copy link
Member

Nyholm commented Dec 22, 2016

Thank you.

webmozart/path-util#22
@sagikazarmark
Copy link
Member

Actually: would it make sense to add some tests with special characters?
@Nyholm
Copy link
Member

Nyholm commented Dec 22, 2016

I was wrong merging this. pathinfo is also locale aware. Im trying to find a solution.
@GreenSuslik
Copy link
Contributor Author

@Nyholm in offical php doc only basename have locale aware caution, pathinfo not have it
@Nyholm
Copy link
Member

Nyholm commented Dec 22, 2016

It does.. http://php.net/manual/en/function.pathinfo.php#refsect1-function.pathinfo-notes
@GreenSuslik
Copy link
Contributor Author

GreenSuslik commented Dec 22, 2016 •
edited
Loading

OMG on basename page it is big colored block on top, on pathinfo is similar small small text on bottom page. It's very bad. Pathinfo work with russian file name, but basename not work, it add invalid char to start
@Nyholm
Copy link
Member

Nyholm commented Dec 22, 2016

Im editing the wiki now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@GreenSuslik @Nyholm @sagikazarmark