Skip to content

change basename to pathinfo #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

change basename to pathinfo #17

wants to merge 1 commit into from

Conversation

GreenSuslik
Copy link
Contributor

Detail in #16
Nyholm
Nyholm requested changes Dec 21, 2016
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR.
.gitignore
@@ -1,4 +1,5 @@
.puli/
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the .gitignore.

You should put this in your global .gitignore file.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok
@Nyholm
Copy link
Member

Nyholm commented Dec 21, 2016

No, why did you close this PR? Just push the changes. =)
@Nyholm Nyholm reopened this Dec 21, 2016
@GreenSuslik
Copy link
Contributor Author

sorry, i'm use gitlab usually. I'd not know how do it in github.
@Nyholm
Copy link
Member

Nyholm commented Dec 21, 2016

You just push more changes to your master branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@GreenSuslik @Nyholm