have the mock client provide the PSR client implementation as well #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We need to bump httplug to version 2 because version 1 did not implement the PSR interface. Version 2 implements both the php-http interface as well as the PSR interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We need to bump httplug to version 2 because version 1 did not implement
the PSR interface. Version 2 implements both the php-http interface as
well as the PSR interface.
What's in this PR?
Have the mock client provide the PSR client implementation as well.
Why?
This was intended but went under. We have to jump to HTTPlug 2.0 as that has the php-http client interface extend the PSR interface.
Checklist