- Notifications
You must be signed in to change notification settings - Fork 17
Closed
Description
Q | A |
---|---|
Bug? | no |
New Feature? | no |
Version | v1.0.1 |
On the exceptions
property:
Lines 42 to 45 in 7b47440
/** | |
* @var Exception[] | |
*/ | |
private $exceptions = []; |
The type hinting corresponds to Http\Client\Exception
But on the adder:
Lines 74 to 82 in 7b47440
/** | |
* Adds an exception that will be thrown. | |
* | |
* @param \Exception $exception | |
*/ | |
public function addException(\Exception $exception) | |
{ | |
$this->exceptions[] = $exception; | |
} |
It corresponds to \Exception
.
AFAIK, it makes no sense. Which one should be choose?
I may add a PR after getting #21 merged.
Metadata
Metadata
Assignees
Labels
No labels