Skip to content

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 2, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

This PR

  • requires localheinz/composer-normalize as development dependency
  • runs composer validate and composer normalize --dry-run on Travis
  • normalizes composer.json

💁‍♂️ For reference, see https://github.com/localheinz/composer-normalize.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nice one! we could add a check into the ci (with --dry-run) to keep the file clean, wdyt? does dry-run have a non-0 return value if there are changes?

@localheinz localheinz force-pushed the feature/normalize branch 2 times, most recently from 552df01 to f5eb014 Compare August 3, 2019 17:55
@localheinz
Copy link
Contributor Author

@dbu

I have made a few changes, thank you for suggesting to use localheinz/composer-normalize in the build pipeline!

@localheinz
Copy link
Contributor Author

@dbu
Copy link
Contributor

dbu commented Aug 5, 2019

does that mean that scrutinizer is using an outdated version of composer? can you check with the scrutinizer people? that said, i personally don't look at the scrutinizer output much - we could also drop it imho.

@dbu dbu merged commit 274c2c2 into php-http:master Aug 19, 2019
@localheinz localheinz deleted the feature/normalize branch August 19, 2019 13:54
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants