Remove internal deprecation notice #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I see that this removes the deprecation warning when using ie |
| Not sure how this was used, so i made this to be fully BC compatible, but we can remove setting this value if you want |
| Im fine with the current implementation. I just wanted to make sure. |
dbu approved these changes Jul 10, 2018
| Any news on this? |
| i have no experience with the php stream code, so i don't feel confident enough to merge this one. if people agree that this is the right way to do it, lets merge it. |
sagikazarmark approved these changes Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This remove internal deprecation notices and still respect bc promise, by implementing construct in each implementation.