fix: buzz client instantiation using deprecated Message Factory Discovery #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes the instantiation of Buzz client to use the new `Psr17FactoryDiscovery` instead of the deprecated `MessageFactoryDiscovery`.
fix: buzz client factory
dbu approved these changes Jul 11, 2023
There was a problem hiding this comment.
we seem to not have an installation test with buzz but checking the code, the client accepts both factories since 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes the instantiation of Buzz client to use the new
Psr17FactoryDiscoveryinstead of the deprecatedMessageFactoryDiscovery.What's in this PR?
Change Buzz instantiator from the deprecated
MessageFactoryDisvoveryto the newPsr17FactoryDiscovery.Why?
The Buzz Instantiator was using the deprectaed
MessageFactoryDiscoveryand this was causing an exception when attempting to instantiate Buzz usingnyholm/psr7. Changed to the more modernPsr17FactoryDiscoverythat does findnyholm/psr7for Buzz.Example Usage
Noop
Checklist