Add method to retrieve currently configured strategies

[gsteel]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	none
Documentation	Will supply if appropriate/acceptable feature
License	MIT

What's in this PR?

Adds a method to retrieve the currently configured discovery strategies.

Why?

When testing a consumer, it is useful to clear strategies to simulate a Not Found Exception, i.e. Psr18ClientDiscovery::setStrategies([])' but in order to reinstate the default behaviour of the lib after doing this, strategies would need to be duplicated in consumer tests.

Example Usage

$currentStrategies = Psr18ClientDiscovery::getStrategies(); Psr18ClientDiscovery::setStrategies([]); try { // Test my thing… $this->fail('An exception was not thrown'); } catch (ExpectedError $error) { $this->makeMoreAssertions(); } finally { Psr18ClientDiscovery::setStrategies($currentStrategies); }

Checklist

• Updated CHANGELOG.md to describe new feature
• Documentation pull request created (if not simply a bugfix)

To Do

• Tests… Sorry, I'm not familiar with phpspec but would be happy to write a unit tests??

[dbu]

seems a valid reason to me. as we have the setter, having a way to know and restore the previous state seems useful to me.

for the test, maybe you can take this test as a starting point?
https://github.com/php-http/discovery/blob/master/spec/ClassDiscoverySpec.php#L61 (the main difference is that in phpspec, you call $this-> to call something on the class you are testing.) so in your case $this->getStrategies()->shouldReturn([...]);

can you please rebase on master? there is a conflict, i assume because of another change that also added to the changelog.

[gsteel]

Thanks for the phpspec pointers @dbu - pull duly rebased. Sorry for the noisy commits!

[dbu]

thanks!