Skip to content

Cleaned up some tests & prepare 3.0 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 1, 2020
Merged

Cleaned up some tests & prepare 3.0 #51

merged 8 commits into from
Oct 1, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 1, 2020 •
edited
Loading

Just making sure tests are passing.

I removed Travis because it is super slow.

The tests that fail is just because they need to add some return annotations. This is fine since we are doing a new major release.
@Nyholm
Copy link
Member Author

Nyholm commented Oct 1, 2020

@dbu I want to merge this and release 3.0.
@Nyholm Nyholm changed the title Cleaned up some tests Cleaned up some tests & prepare 3.0 Oct 1, 2020
dbu
dbu approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanups. do you want to keep the failing builds or should we disable them until somebody finds time to fix them?
@Nyholm
Copy link
Member Author

Nyholm commented Oct 1, 2020

We should keep them. This CI just want to check how "other clients" behave with the suggested changes.
@Nyholm Nyholm merged commit 6db507a into master Oct 1, 2020
@Nyholm Nyholm deleted the cleanup branch October 1, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Nyholm @dbu