Fix: Drop support for unsupported PHP versions #336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
localheinz force-pushed the fix/php branch 3 times, most recently from 4db0809 to 4332466 Compare 1 task
| Looks like this doesn't actually fix the build, but requires more work. |
| thanks. looking at https://travis-ci.org/php-http/HttplugBundle/jobs/539402830 i think its also time to ditch symfony 2 support, wdyt? a lot of builds are red because of deprecations that are not actual bugs. we might still adjust to avoid the deprecation to be future proof. |
2 tasks
| did all of the removing old stuff in #340 |
| Thank you, @dbu! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR
Why?
The build is currently broken as
php-http/vcr-plugin:^1.0@devrequires PHP 7.1.Example Usage
n/a
Checklist
CHANGELOG.mdto describe BC breaksTo Do
n/a