1.3.0 dev #20
Merged
1.3.0 dev #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Failing test written as confirmation of issue #15 * added remembered file entity * construct from and export to UploadedFile * Compose with RememberedFile instead of array * Use Illuminate UploadedFile, this is for Laravel after all * working towards solving #15 * Memo to self * notes * Made much more DRY * Wrote testArrayFileUploadOldRemembered test * Added RememberedFileBag * Refactored to add functionality for issue #15 * Removed final inspection warning * Added failing test for checking validation errors invalidate array uploads * Update to support laravel 5.4 as a minimum * Fix unit test * Remove composer.lock this is a lib not a project
Adding test to reproduce issue raised by Jarosław Goszowski
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Blocked by #17 and #16