Create option to maintain structure of your data. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Jatidude changed the title 
philipstanislaus requested changes Aug 27, 2019
| I made a commit does that automatically get applied? I'm not fully show how this works |
| @Jatidude thanks, looks great! I did some cleanup, please check. If you approve, I'll merge. Thanks for your first FOSS contribution! |
philipstanislaus approved these changes Aug 28, 2019
Jatidude commented Aug 28, 2019
| @philipstanislaus is there something else I need to do before this gets merged? Sorry if I'm jumping the gun just want to make sure there's nothing more you need me to do. |
| @Jatidude sorry for the late reply, I was travelling. Just merged, will deploy in a bit! |
philipstanislaus added a commit that referenced this pull request Sep 3, 2019
Add option to maintain structure of your data. (#6)
| @Jatidude all done, released as v1.2.0: https://www.npmjs.com/package/performant-array-to-tree Thanks for your contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is my first ever contribution to an open source repository so if i did something wrong just let me know. I changed the README to reflect the changes that I made but It could probable be cleaned up.