Skip to content

Handle case where parentId field does not exist #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Handle case where parentId field does not exist #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/arrayToTree.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,31 @@ describe('arrayToTree', () => {
])
})

it('should work with nested objects with dataField set to null and some parentIds not existing', () => {
expect(arrayToTree(
([
{ id: '4', custom: 'abc' },
{ id: '31', parentId: '4', custom: '12' },
{ id: '1941', parentId: '418', custom: 'de' },
{ id: '1', parentId: '418', custom: 'ZZZz' },
{ id: '418', custom: 'ü' },
]),
{ id: 'id', parentId: 'parentId', dataField: null },
)).to.deep.equal([
{
id: '4', custom: 'abc', children: [
{ id: '31', parentId: '4', custom: '12', children: [] },
],
},
{
id: '418', custom: 'ü', children: [
{ id: '1941', parentId: '418', custom: 'de', children: [] },
{ id: '1', parentId: '418', custom: 'ZZZz', children: [] },
],
},
])
})

it('should work with nested objects and custom keys with dataField set to null', () => {
expect(arrayToTree(
([
Expand Down
2 changes: 1 addition & 1 deletion src/arrayToTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function arrayToTree (items: Item[], config: Partial<Config> = {}): TreeI

const TreeItem = lookup[itemId]

if (parentId === null) {
if (!parentId) {
// is a root item
rootItems.push(TreeItem)
} else {
Expand Down