re-implemented theme watch tasks, add parallel tasks, added ability to c... #48
Conversation
…o create dynamic parallel targets
tasks/parallel.js Outdated
tasks/watch.js Outdated
There was a problem hiding this comment.
What happens with live reload when run on a remote server?
There was a problem hiding this comment.
I'm actually not sure. I tried to do some research on this to get you an authoritative answer, but I'm not getting anything definite. I think it's possible that you may have to tunnel the necessary livereload port, so given that complexity, this also might be something to remove from GDT and let users handle in their own custom tasks. Totally your call.
There was a problem hiding this comment.
If it's low overhead for a no-op, I'm okay with leaving it. If it causes some resource spike or UI thrashing I think we need to disable it, or only include the functionality if the SSH session is not remote.
In fact, remoteness-detection for inclusion might be a good step regardless.
There was a problem hiding this comment.
Right. I'm really not sure about the possible unintended consequences, so I think it's best to just remove it and leave for it people to implement on their own.
| Fixes #13 |
| Based on feedback from @grayside, I removed the parallel.js file and the livereload integration in watch.js to keep GDT lean and simple. So all this fork does now is integrate parallel with the watch tasks. |
| Merging this into my original branch so we can look at the full changeset on a new PR. |
re-implemented theme watch tasks, add parallel tasks, added ability to c...
2 participants
...reate dynamic parallel targets