Skip to content

fixed getRelated already fetched relations #16449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from
Open

fixed getRelated already fetched relations #16449

wants to merge 1 commit into from

Conversation

@rudiservo
Copy link
Contributor

@rudiservo rudiservo commented Oct 2, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
GetRelated should reuse already fetched relation inside the model, avoiding more hits to the database.
If devs need fresh data they can use Model::refresh and with the PR also ResultSet::refresh.

Thanks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@rudiservo