Update to h2.events interface as of 4.3.0 #326
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
h2 introduced a (possibly accidental) backward-incompatible change to the event classes. This results in issue pgjones#318.
Kriechi approved these changes Oct 14, 2025
Kriechi referenced this pull request in python-hyper/h2 Oct 14, 2025
Owner
| Thanks, fixed in 07a7b14 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Due to a change in the interface of
h2.events's classes that was backwards-incompatible (but perceived as backwards-compatible by the committer), there is a bug (#317 and #318) when receiving any HTTP/2 requests whileh2 >= 4.3.0is installed.This merge request updates the dependency to
h2 >= 4.3.0and changes the constructor call to match the new interface.Additionally, the merge request adds more Python versions to the Tox configuration.