Clean up the K2 build config #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Set LV to 2.1, and restore the 1.8 JVM target.
lppedd force-pushed the build/k2-cleanup branch from 2aaf180 to 36f80c8 Compare 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #135 +/- ## ============================================ - Coverage 85.10% 84.82% -0.29% + Complexity 219 218 -1 ============================================ Files 29 29 Lines 658 659 +1 Branches 117 117 ============================================ - Hits 560 559 -1 - Misses 69 71 +2 Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lppedd commented Mar 31, 2025
petertrr approved these changes Apr 8, 2025
| watchosDeviceArm64() | ||
| | ||
| // Deprecated. | ||
| // Should follow the same route as official Kotlin libraries |
There was a problem hiding this comment.
WDYM by the same route? Sorry, I'm not keeping up with the recent context
There was a problem hiding this comment.
@petertrr basically we should stick to what kotlinx libs do: build for all targets, even if deprecated.
Once (and if) it will get removed, we'll delete that line.
There was a problem hiding this comment.
Ok, thanks for the clarification!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
KotlinVersion.KOTLIN_2_1: this means we're effectively compiling with K2JvmTarget.JVM_1_8: no real reason to bump it to 11 imo, but in case let me know the rationalekotlin.native.enableKlibsCrossCompilation@petertrr you can also refactor the publishing step to publish everything in one go now.