[pull] master from bambulab:master #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
## UI/UX Changes ### Simplified Optimization Settings Layout - Removed "Advanced Settings" collapsible section in favor of a cleaner, more intuitive layout - Promoted "Layers to Optimize" to top-level, always-visible field for better accessibility - Added new "Limits" dropdown with two options: - "Helio default (recommended)": Uses backend optimization values (default) - "Slicer default": Shows manual input fields for velocity and volumetric speed ### Conditional Field Visibility - Velocity and volumetric speed fields now hidden by default when "Helio default" is selected - Fields become visible when user selects "Slicer default" option - Maintains same functionality as previous advanced settings behavior ### Forced Mode Behavior (Restored) - Automatically forces "Slicer default" mode when: - Nozzle diameter = 0.2mm, OR - Layer height < 0.2mm - Disables Limits dropdown when forced to prevent user override - These edge cases require manual tuning and cannot use Helio defaults ### UI Polish - Updated "Buy Now" link text to "Buy Now / Manage Account" - Increased Limits dropdown width from 120px to 350px to prevent clipping of "Helio default (recommended)" text - Maintains consistent dark mode theming ## Code Quality Improvements ### Maintainability - Replaced magic numbers with named constants: - `LIMITS_HELIO_DEFAULT = 0` - `LIMITS_SLICER_DEFAULT = 1` - `LIMITS_DROPDOWN_WIDTH = 350` - Improved code readability and reduced risk of errors ## Technical Details ### Modified Files - `src/slic3r/GUI/HelioReleaseNote.cpp`: Primary UI restructuring and logic - `src/slic3r/GUI/HelioReleaseNote.hpp`: Added `panel_velocity_volumetric` member, updated `create_combo_item` signature to support custom width ### Backward Compatibility - Maintains all existing functionality - No API changes to public interfaces - Dialog lifecycle handles state reset (no persistent state issues) ## Testing - Verified UI layout changes across light and dark modes - Confirmed forced mode behavior for 0.2mm nozzle and layer height < 0.2 - Tested dropdown selection toggling field visibility - Validated local builds on macOS (Debug and Release configurations)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )