🐛 Add PGP Fix for New Email API #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
esinx approved these changes Sep 22, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM pennlabs/django-base:b269ea1613686b1ac6370154debbb741b012de1a-3.9.14 | |||
| FROM pennlabs/django-base:b269ea1613686b1ac6370154debbb741b012de1a-3.11 | |||
| @@ -0,0 +1,47 @@ | |||
| import os | |||
Member
There was a problem hiding this comment.
"staging" env makes more sense so I basically copied prod and removed cert envs
| | ||
| # Collect static files | ||
| RUN python3 /app/manage.py collectstatic --noinput | ||
| RUN python3 /app/manage.py collectstatic --noinput |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Patch Platform Dev by adding similar config to platform
Long term we should try to make the two extend from a base and not diverge (e.g. platform extend from platform dev and adds additional config).