This repository was archived by the owner on May 1, 2021. It is now read-only.
Add ability to quickly create enum params #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pbeshai suggested changes Dec 14, 2020
Owner
pbeshai left a comment
pbeshai left a comment There was a problem hiding this comment.
Thanks for this, it's a convenient parameter that I've also created similar versions of in the past. One minor request, but otherwise looks great.
src/serialize.ts Outdated
Comment on lines 271 to 272
| const isEnumMember = (str: string): str is T => enumValues.includes(str as any) | ||
| return isEnumMember(str) ? str : undefined |
Owner
There was a problem hiding this comment.
Can we avoid creating this intermediate function by writing the code this way?
return enumValues.includes(str as any) ? str as T : undefined
Owner
| Thank you! Published in v1.3.0 |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've been using
use-query-paramsin my TS project and there're times whenStringParamis not enough. E.g. when storing filter values in query, I want to check that these values are compatible with TS enum. For that purpose I added simple function to ease the creation of custom enum params.Example:
Decided to submit PR with these changes in case it would be helpful for others too