- Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: show fields inside groups as separate columns in the list view #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show fields inside groups as separate columns in the list view #7355
Conversation
| @JarrodMFlesch Ref the comment you made in #7331, that this was not for now. I wanted to work more on it. I also wanted to know what you think about the column header/label. In filters this has a > for nested fileds. Like this: |
| @andershermansen I think this is a very welcome improvement 😃 As for labels, using the caret is probably wise in the column headers as well! |
| @JarrodMFlesch Great! I’m on leave for the rest of this week, will pick this up and implement the rest next week. |
6b7fcca to bcebda0 Compare bcebda0 to 52cf7f9 Compare | @JarrodMFlesch This is now ready for review. The lint error is in a file I have changed, but it's not my change. All other tests are green and I added test case for the new feature. |
| @JarrodMFlesch Did you (or anybody else in payload team) had a chance to take a look? |
| Maybe |
| That's a great addition, thanks @andershermansen! I hope this gets reviewed and merged soon :) |
| This PR is stale due to lack of activity. To keep the PR open, please indicate that it is still relevant in a comment below. |
| I came here looking for a way to display individual grouped columns. I hope this feature gets reviewed and merged in. |
…lumns-for-group-fields
…lumns-for-group-fields
…lumns-for-group-fields
…lumns-for-group-fields
DanRibbens left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion for this
… moveSubFieldsToTop
…lumns-for-group-fields
Resolves conflicts from PR #7355 --------- Co-authored-by: Jacob Fletcher <jacobsfletch@gmail.com> Co-authored-by: Keisuke Ikeda <ksk1kd.dev@gmail.com> Co-authored-by: Alessio Gravili <alessio@gravili.de> Co-authored-by: Dan Ribbens <DanRibbens@users.noreply.github.com> Co-authored-by: Sasha <64744993+r1tsuu@users.noreply.github.com> Co-authored-by: Paul <paul@payloadcms.com> Co-authored-by: Germán Jabloñski <43938777+GermanJablo@users.noreply.github.com> Co-authored-by: Anders Semb Hermansen <anders.hermansen@gmail.com>
| 🚀 This is included in version v3.39.0 |
| @DanRibbens @andershermansen this is a great addition! However, it appears to be a breaking change. The previous group (data in json) column is not available any more. We had custom cell rendering for these fields. Since the aggregated column is not present anymore this completely breaks! Can we get a hoffix that restores compatibility with the old behaviour? |
…t view (#12530) ### What Continuation of #7355 by extending the functionality to named tabs. Updates `flattenFields` to hoist nested fields inside named tabs to the top-level field array when `moveSubFieldsToTop` is enabled. Also fixes an issue where group fields with custom cells were being flattened out. Now, group fields with a custom cell components remain available as top-level columns. Fixes #12563







Description
Group fields are shown as one column, this PR changes this so that the individual field is now shown separately.
Before change:

After change:

Type of change
Checklist: