fix(richtext-lexical): modify JSXConvertersFunction type to support block types in strict mode #10398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GermanJablo requested review from DanRibbens, denolfe and jmikrut as code owners 
Contributor
| 🚀 This is included in version v3.15.0 |
GermanJablo added a commit that referenced this pull request Jan 20, 2025
updating pnpm-lock was necessary due to #10398
kendelljoseph pushed a commit that referenced this pull request Feb 21, 2025
…lock types in strict mode (#10398) Reproduction steps: 1. Set `strict: true` in `templates/website/tsconfig.json` 2. You will find a ts error in `templates/website/src/components/RichText/index.tsx`. This is because the blockType property of blocks is generated by Payload as a literal (e.g. "mediaBlock") and cannot be assigned to a string. To test this PR, you can make the change to `JSXConvertersFunction` in node_modules of the website template
kendelljoseph pushed a commit that referenced this pull request Feb 21, 2025
updating pnpm-lock was necessary due to #10398
AlessioGr added a commit that referenced this pull request May 21, 2025
…JSXConvertersFunction type (#12478) Same as #10398 but for inline blocks. > Reproduction steps: > 1. Set `strict: true` in `templates/website/tsconfig.json` > 2. You will find a ts error in `templates/website/src/components/RichText/index.tsx`. > > This is because the blockType property of blocks is generated by Payload as a literal (e.g. "mediaBlock") and cannot be assigned to a string. > > To test this PR, you can make the change to `JSXConvertersFunction` in node_modules of the website template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reproduction steps:
strict: trueintemplates/website/tsconfig.jsontemplates/website/src/components/RichText/index.tsx.This is because the blockType property of blocks is generated by Payload as a literal (e.g. "mediaBlock") and cannot be assigned to a string.
To test this PR, you can make the change to
JSXConvertersFunctionin node_modules of the website template