ADD: RemoveLineBreaks function #20
Conversation
| @patil-ashutosh , do i need to setup codecov token for this PR to be merged ? |
regex/rstring/string_test.go Outdated
| result := "One,two three!'" | ||
| output := rstring.RemoveLineBreaks(input) | ||
| diff := reflect.DeepEqual(result, output) | ||
| |
There was a problem hiding this comment.
@binkkatal please modify method such that we can test for multiple inputs with ease, check other methods in this file
There was a problem hiding this comment.
@patil-ashutosh , added subtest , ready for re-review
| @binkkatal you need to refresh branch first. might be need to resolve conflicts How to refresh branch: Or let me know , I will resolve conflicts |
RemoveLineBreaks removes all line breaks from a string using a regex. As per https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html#lineending, Any Unicode linebreak sequence, is equivalent to \u000D\u000A|[\u000A\u000B\u000C\u000D\u0085\u2028\u2029] .
binkkatal force-pushed the feature/17_line_breaks branch from 6ea4655 to 3932dc4 Compare | @patil-ashutosh , rebased, was waiting for the token missing fix |
| @binkkatal Thanks for working on this. You can also work on open new issue/feature relevant to this repo |
2 participants
RemoveLineBreaks removes all line breaks from a string using a regex.
As per https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html#lineending,
Any Unicode linebreak sequence, is equivalent to \u000D\u000A|[\u000A\u000B\u000C\u000D\u0085\u2028\u2029] .