Skip to content

Conversation

@binkkatal
Copy link
Contributor

ADD: Check for special characters in a string.

The Method ContainsSpecialChars, uses regex to validate a string.
The regex being used is ^[a-zA-Z0-9]*$

@patil-ashutosh
Copy link
Owner

@binkkatal Thank your for raising your pull request.

)

var (
isStringAlphabetic = regexp.MustCompile(`^[a-zA-Z0-9]*$`).MatchString
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binkkatal please try to address these comments.

Copy link
Owner

@patil-ashutosh patil-ashutosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@binkkatal Please address comments. Feel free to ping if need any help

@binkkatal binkkatal force-pushed the feature/11-special-characters branch from aa6d42c to 216ef3f Compare October 6, 2020 02:47
@binkkatal
Copy link
Contributor Author

@patil-ashutosh fixed the lint issues and squashed the commits.
ready for re review

@binkkatal
Copy link
Contributor Author

@patil-ashutosh do i need to setup codecov token for this pr to be merged?

@patil-ashutosh patil-ashutosh linked an issue Oct 6, 2020 that may be closed by this pull request
2 tasks
@patil-ashutosh
Copy link
Owner

@patil-ashutosh do i need to setup codecov token for this pr to be merged?

@binkkatal No need to setup token , I fixed CodeCov issue so no need of token.
Please refresh branch once , issue will resolve

@binkkatal binkkatal force-pushed the feature/11-special-characters branch from 216ef3f to 79ba6a0 Compare October 6, 2020 05:26
@binkkatal
Copy link
Contributor Author

@patil-ashutosh do i need to setup codecov token for this pr to be merged?

@binkkatal No need to setup token , I fixed CodeCov issue so no need of token.
Please refresh branch once , issue will resolve

@patil-ashutosh i rebased with the latest master and the upload step breaks again.
can you have a look at it

@patil-ashutosh patil-ashutosh merged commit ebd6687 into patil-ashutosh:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants