fix: multiple issues around analytics #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1. fix for multiple calls happening to analytics server global variable to hold latest version sets when server starts get from global variable in about api call 2. send `X-P-Stream` header in POST call to analytics server resolves the issue of hardcoded stream in analytics server code
nitisht changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix for multiple calls happening to analytics server
global variable to hold latest version
sets when server starts
get from global variable in about api call
send
X-P-Streamheader in POST call to analytics serverresolves the issue of hardcoded stream in analytics server code