Skip to content

Conversation

parmesant
Copy link
Contributor

Fixes #824 and Failing builds on windows

Description

For #824, the file path being passed to PartitionedFile struct is being modified if the storage_mode is drive (for s3-store, and blob-store the current code works just fine)

For failing windows builds, a cfg!() is added to tokio::select! macro to handle different signals for different underlying OS


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
@parmesant parmesant force-pushed the windows-build-path-fix branch from 87d3581 to 88dea62 Compare October 29, 2024 11:30
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nitisht nitisht merged commit 2bc2b3e into parseablehq:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants