refactor: use middlewares to reject requests when shutting down #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

nitisht merged 1 commit into parseablehq:main from de-sh:refactor-shutdown

Oct 25, 2024

Contributor

de-sh commented Oct 25, 2024 •

edited

Loading

Fixes #XXXX.

Description

The idea behind this PR is to not have multiple copies of the shutdown handler code and as a BREAKING CHANGE it WILL result in all requests to ingest/query/server to be rejected with HTTP 503 status when SIGNAL_RECEIVED is set to true.

This PR has:

been tested to ensure log ingestion and log query works.
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added documentation for new or modified features or behaviors.

refactor: use middlewares to reject requests when shutting down

b69a77b

de-sh commented

View reviewed changes

server/Cargo.toml

      ### actix dependencies  
    actix-web-httpauth = "0.8"  
    actix-web = { version = "4.5.1", features = ["rustls-0_22"] }  
    actix-web = { version = "4.9.0", features = ["rustls-0_22"] }  
 

Contributor Author

de-sh Oct 25, 2024 •

edited

Loading

previously from_fn was part of an experimental crate, now it is in main

de-sh marked this pull request as ready for review

October 25, 2024 06:46

nikhilsinhaparseable approved these changes

View reviewed changes

Contributor

nikhilsinhaparseable left a comment

looks good to merge

nitisht merged commit d2df652 into parseablehq:main

8 checks passed

de-sh deleted the refactor-shutdown branch

October 25, 2024 09:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment