Skip to content

Conversation

parmesant
Copy link
Contributor

closes #949

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
@parmesant parmesant force-pushed the upgrade-deps branch 2 times, most recently from dad3fe3 to ebd1038 Compare October 1, 2024 06:33
@nitisht nitisht marked this pull request as ready for review October 1, 2024 10:57
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 2dbb0a8 into parseablehq:main Oct 3, 2024
8 checks passed
@parmesant parmesant deleted the upgrade-deps branch October 3, 2024 10:05
parmesant added a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
parmesant added a commit to parmesant/parseable that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants