fix: OAuth error #934
Merged
fix: OAuth error #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
issue: already borrowed: BorrowMutError when try login with oauth because of req.connection_info() which makes an immutable borrow of req method extract_session_key_from_req() also borrows req because of which the server panics with the error fix is to use connection_info().clone() to avoid multiple borrows
parmesant pushed a commit to parmesant/parseable that referenced this pull request Sep 26, 2024
issue: already borrowed: BorrowMutError when try login with oauth because of req.connection_info() which makes an immutable borrow of req method extract_session_key_from_req() also borrows req because of which the server panics with the error fix is to use connection_info().clone() to avoid multiple borrows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
issue: already borrowed: BorrowMutError when try login with oauth because of req.connection_info()
which makes an immutable borrow of req method extract_session_key_from_req() also borrows req
because of which the server panics with the error
fix is to use connection_info().clone() to avoid multiple borrows