merge trino query code changes to main #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nikhilsinhaparseable force-pushed the trino-merge branch from 4685f03 to cc8cf38 Compare if all env vars specific to Trino are set - P_TRINO_ENDPOINT P_TRINO_CATALOG_NAME P_TRINO_SCHEMA P_TRINO_USER_NAME About API Response sample - ` { "version": "v1.5.0", "uiVersion": "development", "commit": "cc8cf38", "deploymentId": "01J649HC5HPRNVD0VNK7Q6JMFY", "updateAvailable": false, "latestVersion": "v1.5.0", "llmActive": false, "llmProvider": null, "oidcActive": false, "license": "AGPL-3.0-only", "mode": "Distributed (Query)", "staging": "", "hotTier": "Disabled", "grpcPort": 8001, "store": { "type": "S3 bucket", "path": "https://s3.us-east-2.amazonaws.com/clickbenchtest" }, "analytics": { "clarityTag": null }, "queryEngine": "Trino" } ` if any of the above env var is missing, server will return About API response as - ` { "version": "v1.5.0", "uiVersion": "development", "commit": "cc8cf38", "deploymentId": "01J649HC5HPRNVD0VNK7Q6JMFY", "updateAvailable": false, "latestVersion": "v1.5.0", "llmActive": false, "llmProvider": null, "oidcActive": false, "license": "AGPL-3.0-only", "mode": "Distributed (Query)", "staging": "", "hotTier": "Disabled", "grpcPort": 8001, "store": { "type": "S3 bucket", "path": "https://s3.us-east-2.amazonaws.com/clickbenchtest" }, "analytics": { "clarityTag": null }, "queryEngine": "Parseable" } ` based on the field `queryEngine` console can decide whether to user /query or /trinoquery endpoint 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.